[Doc] updating torch.compile doc link #25989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per this PR: #22524, config.py is split up into different files in this folder. Signed-off-by: nadathurv <[email protected]>
ghost
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates an outdated link in the torch.compile design document. The original link pointed to vllm/config.py, which is no longer accurate after recent refactoring. The change updates the link to point to the vllm/config directory, which contains all the relevant configuration files with compute_hash methods. This is a good approach as it is more maintainable than listing individual files. The change is correct and improves the documentation's accuracy.
ghost
changed the title
ghost
closed this
ghost
deleted the
ghost
reopened this
hmellor
requested changes
Sep 30, 2025
Signed-off-by: WorldExplored <[email protected]>
WorldExplored
force-pushed
the
patch-1
branch
from
76e989e to
b8a972d
Compare
|
Yes that should work, that will create a link to the directory on GitHub |
Signed-off-by: nadathurv <[email protected]>
|
You can verify the link works at https://vllm--25989.org.readthedocs.build/en/25989/design/torch_compile.html (once it's finished building your most recent commit) |
hmellor
approved these changes
Sep 30, 2025
@hmellor works. thanks |
github-actions
bot
added
the
ready
pdasigi
pushed a commit
to pdasigi/vllm
that referenced
this pull request
Oct 2, 2025
Signed-off-by: nadathurv <[email protected]> Signed-off-by: WorldExplored <[email protected]> Co-authored-by: Srreyansh Sethi <[email protected]>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: nadathurv <[email protected]> Signed-off-by: WorldExplored <[email protected]> Co-authored-by: Srreyansh Sethi <[email protected]> Signed-off-by: yewentao256 <[email protected]>
tomeras91
pushed a commit
to tomeras91/vllm
that referenced
this pull request
Oct 6, 2025
Signed-off-by: nadathurv <[email protected]> Signed-off-by: WorldExplored <[email protected]> Co-authored-by: Srreyansh Sethi <[email protected]> Signed-off-by: Tomer Asida <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: nadathurv <[email protected]> Signed-off-by: WorldExplored <[email protected]> Co-authored-by: Srreyansh Sethi <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: nadathurv <[email protected]> Signed-off-by: WorldExplored <[email protected]> Co-authored-by: Srreyansh Sethi <[email protected]>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: nadathurv <[email protected]> Signed-off-by: WorldExplored <[email protected]> Co-authored-by: Srreyansh Sethi <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: nadathurv <[email protected]> Signed-off-by: WorldExplored <[email protected]> Co-authored-by: Srreyansh Sethi <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this pr: #22524 the doc becomes outdated.
I have the option of listing relevant files like the
__init__.pyandcompilation.py(iscache.pyalso relevant?) but I am not sure if that is the preference here, so I just updated it to the folder.cc @ProExpertProg @hmellor